-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20963/#review42082
-----------------------------------------------------------
Ship it!
Seems like one could pretty easily create a "generic" isolator for cgroup
things that you get once you've mounted a subsystem in a hierarchy and assigned
a pid to a cgroup in that hierarchy so that in the future one could just do:
GenericCgroupIsolator isolator("perf_event");
Not sure how many more 'perf_event' like things there are, but that might be
useful if there are a handful. Maybe a TODO for posterity?
src/slave/containerizer/isolators/cgroups/perf_event.hpp
<https://reviews.apache.org/r/20963/#comment75827>
We don't use these two, so let's not save them!
src/slave/containerizer/isolators/cgroups/perf_event.hpp
<https://reviews.apache.org/r/20963/#comment75829>
Kill newline. ;-)
src/slave/containerizer/isolators/cgroups/perf_event.cpp
<https://reviews.apache.org/r/20963/#comment75828>
Just return an always pending future!
- Benjamin Hindman
On May 1, 2014, 6:42 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20963/
> -----------------------------------------------------------
>
> (Updated May 1, 2014, 6:42 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This isolator only creates the perf_event cgroup and places the executor into
> the cgroup; no performance statistics are gathered/exported.
>
> NOTE: The recover() as implemented is "non-strict"; it will happily recover
> containers even if they don't have a perf_event cgroup present. This permits
> restarting the slave to add this isolator. Existing containers will not be
> isolated. New containers will be isolated.
>
>
> Diffs
> -----
>
> src/Makefile.am f461a1515e7bafac677f2d0bcdd499f57ba3f029
> src/slave/containerizer/containerizer.cpp
> 374a778e62321dfb57c2ad19a3614154596f4b9f
> src/slave/containerizer/isolators/cgroups/perf_event.hpp PRE-CREATION
> src/slave/containerizer/isolators/cgroups/perf_event.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20963/diff/
>
>
> Testing
> -------
>
> Manually tested.
>
> Our current testing code does not easily permit testing different
> combinations of isolators for the MesosContainerizer.
>
>
> Thanks,
>
> Ian Downes
>
>
