----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20963/#review44325 -----------------------------------------------------------
Patch looks great! Reviews applied: [20963] All tests passed. - Mesos ReviewBot On May 29, 2014, 10:08 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20963/ > ----------------------------------------------------------- > > (Updated May 29, 2014, 10:08 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos-git > > > Description > ------- > > This isolator only creates the perf_event cgroup and places the executor into > the cgroup; no performance statistics are gathered/exported. > > NOTE: The recover() as implemented is "non-strict"; it will happily recover > containers even if they don't have a perf_event cgroup present. This permits > restarting the slave to add this isolator. Existing containers will not be > isolated. New containers will be isolated. > > > Diffs > ----- > > src/Makefile.am ffde59be8683dd40cc5bc7cb88cd88c5bc91cf96 > src/slave/containerizer/isolators/cgroups/perf_event.hpp PRE-CREATION > src/slave/containerizer/isolators/cgroups/perf_event.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/20963/diff/ > > > Testing > ------- > > Manually tested. > > Our current testing code does not easily permit testing different > combinations of isolators for the MesosContainerizer. > > > Thanks, > > Ian Downes > >
