[ 
https://issues.apache.org/jira/browse/MESOS-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13994523#comment-13994523
 ] 

Bernd Mathiske commented on MESOS-1316:
---------------------------------------

Thanks for the tests! That's a good starting point. 

Please do not commit the refactoring yet! That would just mean more rebasing 
for me and I have enough of that already to deal with. Anything that touches 
Mesos fetcher code delays MESOS-336 further. IMHO it should be easier to redo 
your refactoring after what I have to offer. In particular, in my patch I had 
already made the same file decision, to have extra files to deal with "fetcher 
stuff". 

I called the new files "mesos_fetcher.hpp/cpp", not "fetcher.hpp/cpp", because 
it only applies to the MesosContainerizer, not to Containerizer in general.



> Implement decent unit test coverage for the mesos-fetcher tool
> --------------------------------------------------------------
>
>                 Key: MESOS-1316
>                 URL: https://issues.apache.org/jira/browse/MESOS-1316
>             Project: Mesos
>          Issue Type: Improvement
>            Reporter: Tom Arnfeld
>            Assignee: Tom Arnfeld
>
> There are current no tests that cover the {{mesos-fetcher}} tool itself, and 
> hence bugs like MESOS-1313 have accidentally slipped though.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to