> On May 9, 2014, 12:59 p.m., Vinod Kone wrote: > > src/tests/master_tests.cpp, lines 430-438 > > <https://reviews.apache.org/r/21249/diff/2/?file=577145#file577145line430> > > > > Can you use the new style which is to call "createTask"?
done - though we don't use it anywhere else in master tests. > On May 9, 2014, 12:59 p.m., Vinod Kone wrote: > > src/tests/master_tests.cpp, lines 479-480 > > <https://reviews.apache.org/r/21249/diff/2/?file=577145#file577145line479> > > > > kill this? why? I want to make sure that i don't get a status update for the task i'm killing. - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21249/#review42599 ----------------------------------------------------------- On May 9, 2014, 1:11 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21249/ > ----------------------------------------------------------- > > (Updated May 9, 2014, 1:11 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1321 > https://issues.apache.org/jira/browse/MESOS-1321 > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > src/master/master.hpp 0a350b0b402edb3ca648c91c920043f66c08fe0e > src/master/master.cpp d851a7291acce950ea9391ddfb8813a432aeda34 > src/tests/master_tests.cpp 326392ed03f3cb1321ec21af57a5b0253cf29ef9 > > Diff: https://reviews.apache.org/r/21249/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
