----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19499/#review42520 -----------------------------------------------------------
Could we add a test like we did for the Master? (MasterTest.MetricsInStatsEndpoint). How about we have a TODO to have slave/metrics.cpp where we can define all this stuff? :) src/slave/slave.cpp <https://reviews.apache.org/r/19499/#comment76309> Why are these separate from the other Gauge methods, can they go in the header for now? We could move them all to slave/metrics.cpp in the future. src/slave/slave.cpp <https://reviews.apache.org/r/19499/#comment76310> Can we remove the list logic here since we're not using it yet? Ditto for the destructor. - Ben Mahler On May 2, 2014, 2:19 a.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19499/ > ----------------------------------------------------------- > > (Updated May 2, 2014, 2:19 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1133 > https://issues.apache.org/jira/browse/MESOS-1133 > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > src/slave/slave.hpp ed20dca70cfbbd11dcdb35a074dc1777721f6ca5 > src/slave/slave.cpp cb80609ba421b3b9a4664e600f0e53ecab8574c4 > > Diff: https://reviews.apache.org/r/19499/diff/ > > > Testing > ------- > > make check. ran locally and compared stats.json endpoint to /metrics/snapshot > endpoint. > > > Thanks, > > Dominic Hamon > >
