----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19499/#review42593 -----------------------------------------------------------
Ship it! Will get this committed! I'll clean up the test a bit and re-order the metrics a bit per my comment below. src/slave/slave.hpp <https://reviews.apache.org/r/19499/#comment76407> How about we re-order these a bit by how "fundamental" these are: process::metrics::Gauge uptime_secs; process::metrics::Gauge registered; process::metrics::Counter recovery_errors; process::metrics::Gauge active_frameworks; // TODO(dhamon): Add tasks Gauges. process::metrics::Counter valid_status_updates; process::metrics::Counter invalid_status_updates; process::metrics::Counter valid_framework_messages; process::metrics::Counter invalid_framework_messages; src/tests/slave_tests.cpp <https://reviews.apache.org/r/19499/#comment76409> We can remove these. - Ben Mahler On May 9, 2014, 5:16 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19499/ > ----------------------------------------------------------- > > (Updated May 9, 2014, 5:16 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1133 and MESOS-1332 > https://issues.apache.org/jira/browse/MESOS-1133 > https://issues.apache.org/jira/browse/MESOS-1332 > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > src/slave/slave.hpp ed20dca70cfbbd11dcdb35a074dc1777721f6ca5 > src/slave/slave.cpp ba4bd731bc21cdf853c3d390296252ad4d0901cb > src/tests/slave_tests.cpp 6526952528aaf69d77007b37cf96541162290c33 > > Diff: https://reviews.apache.org/r/19499/diff/ > > > Testing > ------- > > make check. ran locally and compared stats.json endpoint to /metrics/snapshot > endpoint. > > > Thanks, > > Dominic Hamon > >
