> On May 12, 2014, 10:25 p.m., Vinod Kone wrote: > > src/tests/routing_tests.cpp, line 135 > > <https://reviews.apache.org/r/21288/diff/1/?file=577816#file577816line135> > > > > this is not really changing the mtu, but setting the same value. not > > sure if kernel handles it differently. > > > > would it be better to set a different value and reset it back to 'mtu' > > so that the test doesn't have any side-effect? just a thought.
I verified that by setting a different value, and it worked:) I just thought it's better not have any side effect for host loopback device:) I can change it back. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21288/#review42761 ----------------------------------------------------------- On May 9, 2014, 9:49 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21288/ > ----------------------------------------------------------- > > (Updated May 9, 2014, 9:49 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang. > > > Bugs: MESOS-1228 > https://issues.apache.org/jira/browse/MESOS-1228 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/linux/routing/link/link.hpp PRE-CREATION > src/linux/routing/link/link.cpp PRE-CREATION > src/tests/routing_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/21288/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
