> On May 12, 2014, 6:02 p.m., Chi Zhang wrote: > > src/linux/routing/link/link.hpp, line 82 > > <https://reviews.apache.org/r/21288/diff/1/?file=577814#file577814line82> > > > > i think mtu() is enough? like how you named link::ip() and link::mac()?
OK, to be consistent, I'll change that to mtu() and setMTU(). Also, I would like to change setMac to setMAC so that it is consistent. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21288/#review42716 ----------------------------------------------------------- On May 9, 2014, 9:49 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21288/ > ----------------------------------------------------------- > > (Updated May 9, 2014, 9:49 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang. > > > Bugs: MESOS-1228 > https://issues.apache.org/jira/browse/MESOS-1228 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/linux/routing/link/link.hpp PRE-CREATION > src/linux/routing/link/link.cpp PRE-CREATION > src/tests/routing_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/21288/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
