----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20995/#review42756 -----------------------------------------------------------
Looks good, just a small amount of cleanup and we can get this committed! 3rdparty/libprocess/include/process/metrics/gauge.hpp <https://reviews.apache.org/r/20995/#comment76648> Should we be including <stout/none.hpp> as well? 3rdparty/libprocess/include/process/metrics/gauge.hpp <https://reviews.apache.org/r/20995/#comment76649> Thanks for the comment! 3rdparty/libprocess/src/tests/metrics_tests.cpp <https://reviews.apache.org/r/20995/#comment76643> s/forty_two/fortyTwo/ or just make this 'one' or 'zero' to make this as simple as possible. 3rdparty/libprocess/src/tests/metrics_tests.cpp <https://reviews.apache.org/r/20995/#comment76635> Why this indirection? Can't this just return 42 directly? 3rdparty/libprocess/src/tests/metrics_tests.cpp <https://reviews.apache.org/r/20995/#comment76639> What is a "synchgauge"? :) How about we clarify these Gauge names a bit: test/function_gauge test/deferred_gauge test/failed_gauge - Ben Mahler On May 12, 2014, 7:37 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20995/ > ----------------------------------------------------------- > > (Updated May 12, 2014, 7:37 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1286 > https://issues.apache.org/jira/browse/MESOS-1286 > > > Repository: mesos-git > > > Description > ------- > > see summary. > > This allows synchronous Gauge methods which reduces potential process queue > pressure. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/metrics/gauge.hpp > af06534622b3f00c1d1dc5c577527375318fd79a > 3rdparty/libprocess/src/tests/metrics_tests.cpp > 8a131218b858a6571bd520c470eac850a3fd345e > > Diff: https://reviews.apache.org/r/20995/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
