----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20995/#review42724 -----------------------------------------------------------
Bad patch! Reviews applied: [20995] Failed command: ./support/mesos-style.py Error: Checking 428 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+runtime/vlog,+whitespace/comma,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/tab,+whitespace/todo src/authorizer/authorizer.hpp:330: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] 3rdparty/libprocess/include/process/metrics/gauge.hpp:26: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] Total errors found: 2 - Mesos ReviewBot On May 8, 2014, 11:28 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20995/ > ----------------------------------------------------------- > > (Updated May 8, 2014, 11:28 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1286 > https://issues.apache.org/jira/browse/MESOS-1286 > > > Repository: mesos-git > > > Description > ------- > > see summary. > > This allows synchronous Gauge methods which reduces potential process queue > pressure. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/metrics/gauge.hpp > af06534622b3f00c1d1dc5c577527375318fd79a > 3rdparty/libprocess/src/tests/metrics_tests.cpp > 8a131218b858a6571bd520c470eac850a3fd345e > > Diff: https://reviews.apache.org/r/20995/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
