----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21040/#review42749 -----------------------------------------------------------
Ship it! Modulo commenting on the need for the new overloaded invoke() method. - Niklas Nielsen On May 12, 2014, 9:52 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21040/ > ----------------------------------------------------------- > > (Updated May 12, 2014, 9:52 a.m.) > > > Review request for mesos and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Updates 'containers' implementation within the ExternalContainerizer to > forward the call to the ECP. > Adds new 'containers' proto message to containers.proto. > > Some minor cleanups like removing of needless namespace mentions that slipped > through. > > NOTE: The test_containerizer.py implementation of 'containers' is incomplete, > it merely poses as a mock-up. > NOTE: This does *not* fix MESOS-1257. > A complete test_containerizer C++ implementation is upcoming to fix these > notes. > > > Diffs > ----- > > include/mesos/containerizer/containerizer.proto c926a7f > src/examples/python/test_containerizer.py 7bebfee > src/slave/containerizer/external_containerizer.hpp 8fdf097 > src/slave/containerizer/external_containerizer.cpp e51ac66 > > Diff: https://reviews.apache.org/r/21040/diff/ > > > Testing > ------- > > make (tests are currently disabled) > > > Thanks, > > Till Toenshoff > >
