----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21246/#review42554 -----------------------------------------------------------
Ship it! Yeeessssss. 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp <https://reviews.apache.org/r/21246/#comment76362> Can you add a comment here that just explains that we first look through all the possible fields to determine both the set fields and the optional fields with a default that are not set? For posterity it would be nice to mention why ListFields was insufficient. 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp <https://reviews.apache.org/r/21246/#comment76361> Weird indentation here, should be indented up to the '(', see http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Boolean_Expressions#Boolean_Expressions. - Benjamin Hindman On May 8, 2014, 11:29 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21246/ > ----------------------------------------------------------- > > (Updated May 8, 2014, 11:29 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos-git > > > Description > ------- > > Previously, only optional fields which where explicitly set would be > serialized regardless whether default values was present. > This patch adds those fields explicitly. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp ddc13e9 > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp d1a58fc > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h 75a3919 > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc 169e177 > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.proto 2c38489 > > Diff: https://reviews.apache.org/r/21246/diff/ > > > Testing > ------- > > Protobuf test case has been expanded with > 1) Optional field _without_ default value -> should not be serialized. > 2) Optional field _with_ default value -> *should* be serialized > > make check > > > Thanks, > > Niklas Nielsen > >
