----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21246/#review42557 -----------------------------------------------------------
Bad patch! Reviews applied: [21246] Failed command: git apply --index 21246.patch Error: error: patch failed: 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp:473 error: 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp: patch does not apply error: patch failed: 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp:73 error: 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp: patch does not apply error: patch failed: 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h:480 error: 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h: patch does not apply error: patch failed: 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc:53 error: 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc: patch does not apply error: patch failed: 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.proto:63 error: 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.proto: patch does not apply - Mesos ReviewBot On May 9, 2014, 12:26 a.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21246/ > ----------------------------------------------------------- > > (Updated May 9, 2014, 12:26 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos-git > > > Description > ------- > > Previously, only optional fields which where explicitly set would be > serialized regardless whether default values was present. > This patch adds those fields explicitly. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp ddc13e9 > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp d1a58fc > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h 75a3919 > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc 169e177 > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.proto 2c38489 > > Diff: https://reviews.apache.org/r/21246/diff/ > > > Testing > ------- > > Protobuf test case has been expanded with > 1) Optional field _without_ default value -> should not be serialized. > 2) Optional field _with_ default value -> *should* be serialized > > make check > > > Thanks, > > Niklas Nielsen > >
