-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21360/
-----------------------------------------------------------
(Updated May 13, 2014, 9:53 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
mesos-style.py accepts files to lint as args
Accepting the files to lint as args allows users to check the style of specific
files. Using a command like git diff piped to xargs enables checking against
files that are added or modified. The responsibility of filtering files was
removed because it seems to make the most sense to have mesos-style run against
what is given to it rather than filtering certain inputs based on the extension.
Bugs: MESOS-1349
https://issues.apache.org/jira/browse/MESOS-1349
Repository: mesos-git
Description
-------
Previously run_lint was being invoked a large subset of the source tree which
was inefficient. With this change it enables mesos-style.py to potentially be
used as a pre-commit hook.
git diff is used to determine which staged files that have been added or
removed. The intersection between the staged files and all lint candidates is
computed and sent to cpplint. The return value of the mesos-style.py script is
the result of the cpplint process exit or 0 if there the intersection is empty.
Diffs (updated)
-----
support/mesos-style.py bd7dcdb
Diff: https://reviews.apache.org/r/21360/diff/
Testing
-------
./support/mesos-style.py
Thanks,
Steven Phung
