-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21360/
-----------------------------------------------------------
(Updated May 14, 2014, 4:24 a.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Updated for to reflect Vinod's clarifications.
The default behavior when no args are provided is to check the entire source
tree based on the defined rules in code.
If a list of arguments is provided they represent file paths to run lint on.
The file paths that are passed in will be filtered down based on the defined
rules in mesos-style.py which means if it is not a candidate for lint then it
will be ignored. (For now)
Bugs: MESOS-1349
https://issues.apache.org/jira/browse/MESOS-1349
Repository: mesos-git
Description
-------
Previously run_lint was being invoked a large subset of the source tree which
was inefficient. With this change it enables mesos-style.py to potentially be
used as a pre-commit hook.
git diff is used to determine which staged files that have been added or
removed. The intersection between the staged files and all lint candidates is
computed and sent to cpplint. The return value of the mesos-style.py script is
the result of the cpplint process exit or 0 if there the intersection is empty.
Diffs (updated)
-----
support/mesos-style.py bd7dcdb
Diff: https://reviews.apache.org/r/21360/diff/
Testing
-------
./support/mesos-style.py
Thanks,
Steven Phung
