> On May 13, 2014, 1:24 a.m., Vinod Kone wrote: > > src/linux/routing/filter/ip.cpp, line 184 > > <https://reviews.apache.org/r/20297/diff/4/?file=569537#file569537line184> > > > > s/destinationIP/destinationPorts/
Oops! Good catch! This is not captured by the unit test. I added another unit test for capturing the regression. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20297/#review42800 ----------------------------------------------------------- On April 28, 2014, 5:04 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20297/ > ----------------------------------------------------------- > > (Updated April 28, 2014, 5:04 p.m.) > > > Review request for mesos, Benjamin Hindman, Chi Zhang, Ian Downes, Vinod > Kone, and Cong Wang. > > > Bugs: MESOS-1228 > https://issues.apache.org/jira/browse/MESOS-1228 > > > Repository: mesos-git > > > Description > ------- > > The is Part 5 of the linux routing library. > > > Diffs > ----- > > src/Makefile.am d2e006d > src/linux/routing/filter/ip.hpp PRE-CREATION > src/linux/routing/filter/ip.cpp PRE-CREATION > src/tests/routing_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/20297/diff/ > > > Testing > ------- > > make check > sudo make check > > > Thanks, > > Jie Yu > >
