[
https://issues.apache.org/jira/browse/MESOS-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13997271#comment-13997271
]
Dominic Hamon commented on MESOS-1332:
--------------------------------------
h3. grouping
I appreciate the comments regarding JSON and alphabetical ordering. I would
like to consider how the operators will be reading/analysing these metrics
along with that. If we assume that operators will be using grep or regex to
match specific metric names, the ordering may not matter. While keeping the
language as natural as possible is key for readability, we should group things
as much as possible using common prefices:
{code}
tasks_staging
tasks_starting
tasks_running
...
{code}
all read naturally.
{code}
frameworks_active
frameworks_inactive
slaves_active
slaves_inactive
{code}
are a little tortured to read, but I think it's important enough to keep these
together in the JSON that we use the common prefix.
h3. name-spacing
Using the separator to implement name-spacing is a great idea (from [~bmahler]
in a review). We use it now for the top-level component the metric belongs to,
though there has been some discussion about how to manage process IDs in a
multi-slave environment, and I think separating further in regards to specific
Slaves/Frameworks is a very powerful idea. We briefly discussed having a tree
of Metrics and this is another way to think about the separation: Parent-child.
For instance, I could imagine a world in which we have:
{code}
slave/001/message_kill_task
slave/001/message_launch_task
slave/002/message_launch_task
{code}
and just maybe we'd automatically add:
{code}
slave/message_launch_task
{code}
as the sum of the children calculated automatically. This would be more complex
to manage if we embedded the process ID in the top-level path element.
We should also consider statistics, which currently use the separator:
{code}
state_store_ms
state_store_ms/min
state_store_ms/max
{code}
> Improve Master and Slave metric names
> -------------------------------------
>
> Key: MESOS-1332
> URL: https://issues.apache.org/jira/browse/MESOS-1332
> Project: Mesos
> Issue Type: Improvement
> Components: master, slave
> Reporter: Dominic Hamon
> Assignee: Dominic Hamon
>
> As we move the metrics to a new endpoint, we should consider revisiting the
> names of some of the current metrics to make them clearer.
> It may also be worth considering changing some existing counter-style metrics
> to gauges.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
