----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21399/#review42997 -----------------------------------------------------------
Ship it! Please make the metric variable names same as the strings. e.g: s/unregister_slave_messages/messages_unregister_slave/ - Vinod Kone On May 14, 2014, 5:40 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21399/ > ----------------------------------------------------------- > > (Updated May 14, 2014, 5:40 p.m.) > > > Review request for mesos, Dominic Hamon and Vinod Kone. > > > Bugs: MESOS-1338 > https://issues.apache.org/jira/browse/MESOS-1338 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/master.hpp 4f9ae36c822a16ea3baadf6b9fa3616d030d19f2 > src/master/master.cpp d5453673a839326d00a3d45940bd4562c526cff2 > src/tests/master_tests.cpp 7aa678afc94869c8243485bd0604532dec43a1e2 > > Diff: https://reviews.apache.org/r/21399/diff/ > > > Testing > ------- > > make check & visual verification. > > The stats look like this: > > { > master/dropped_messages: 0, > master/event_queue_size: 0, > master/messages_authenticate: 0, > master/messages_deactivate_framework: 0, > master/messages_exited_executor: 0, > master/messages_framework_to_executor: 0, > master/messages_kill_task: 0, > master/messages_launch_tasks: 0, > master/messages_reconcile_tasks: 0, > master/messages_register_framework: 0, > master/messages_register_slave: 0, > master/messages_reregister_framework: 0, > master/messages_reregister_slave: 1, > master/messages_resource_request: 0, > master/messages_revive_offers: 0, > master/messages_status_update: 0, > master/messages_unregister_framework: 0, > master/messages_unregister_slave: 0, > master/recovery_slave_removals: 0, > master/slave_registrations: 0, > master/slave_removals: 0, > master/slave_reregistrations: 1, > registrar/queued_operations: 0, > registrar/registry_size_bytes: 338, > registrar/state_fetch_ms: 0.069774, > registrar/state_store_ms: 0.017632, > registrar/state_store_ms/count: 2, > registrar/state_store_ms/max: 0.029846, > registrar/state_store_ms/min: 0.017632, > registrar/state_store_ms/p50: 0.023739, > registrar/state_store_ms/p90: 0.0286246, > registrar/state_store_ms/p95: 0.0292353, > registrar/state_store_ms/p99: 0.02972386, > registrar/state_store_ms/p999: 0.029833786, > registrar/state_store_ms/p9999: 0.0298447786 > } > > > Thanks, > > Jiang Yan Xu > >
