> On May 15, 2014, 10:42 a.m., Dominic Hamon wrote: > > src/master/master.hpp, line 498 > > <https://reviews.apache.org/r/21399/diff/5/?file=581756#file581756line498> > > > > I thought we decided on: > > > > messages_framework_register > > messages_framework_reregister > > messages_framework_unregister > > ... > > > > so they'd be grouped in the JSON.
Oh I didn't realize your recommendation was different from BenM's. I've pulled "messages_" forward to the beginning as the grouping mechanism. So you want "framework" and "slave" to be put before the verbs, I think that doesn't work well for grouping because only a (small) subset of messages have names "framework" and "slave" in their names even though most of rest do only come from either frameworks or slaves. So in your example "frameworks" and "slaves" groups contain at most 3 entries and messages like "StatesUpdateMessage" and "KillTaskMessage" don't have a group to go to unless we name them as "messages_slave_status_update" and "messages_framework_kill_task" and I am afraid that changes the name too much. We only have < 20 message types and if we can easily identify them from the rest of the snapshot JSON I don't think it's too hard to find them individually from the group. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21399/#review43129 ----------------------------------------------------------- On May 14, 2014, 1:37 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21399/ > ----------------------------------------------------------- > > (Updated May 14, 2014, 1:37 p.m.) > > > Review request for mesos, Dominic Hamon and Vinod Kone. > > > Bugs: MESOS-1338 > https://issues.apache.org/jira/browse/MESOS-1338 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/master.hpp 12111cf7b183438f540bb0aad17e50e3f367558a > src/master/master.cpp 2f0e9027c5bea8066ac13996451d4905a422336e > src/tests/master_tests.cpp dcda0c79a6693bc3c0b69b4c9b148f9608342738 > > Diff: https://reviews.apache.org/r/21399/diff/ > > > Testing > ------- > > make check & visual verification. > > The stats look like this: > > { > master/dropped_messages: 0, > master/event_queue_size: 0, > master/messages_authenticate: 0, > master/messages_deactivate_framework: 0, > master/messages_exited_executor: 0, > master/messages_framework_to_executor: 0, > master/messages_kill_task: 0, > master/messages_launch_tasks: 0, > master/messages_reconcile_tasks: 0, > master/messages_register_framework: 0, > master/messages_register_slave: 0, > master/messages_reregister_framework: 0, > master/messages_reregister_slave: 1, > master/messages_resource_request: 0, > master/messages_revive_offers: 0, > master/messages_status_update: 0, > master/messages_unregister_framework: 0, > master/messages_unregister_slave: 0, > master/recovery_slave_removals: 0, > master/slave_registrations: 0, > master/slave_removals: 0, > master/slave_reregistrations: 1, > registrar/queued_operations: 0, > registrar/registry_size_bytes: 338, > registrar/state_fetch_ms: 0.069774, > registrar/state_store_ms: 0.017632, > registrar/state_store_ms/count: 2, > registrar/state_store_ms/max: 0.029846, > registrar/state_store_ms/min: 0.017632, > registrar/state_store_ms/p50: 0.023739, > registrar/state_store_ms/p90: 0.0286246, > registrar/state_store_ms/p95: 0.0292353, > registrar/state_store_ms/p99: 0.02972386, > registrar/state_store_ms/p999: 0.029833786, > registrar/state_store_ms/p9999: 0.0298447786 > } > > > Thanks, > > Jiang Yan Xu > >
