> On May 8, 2014, 4:22 p.m., Ian Downes wrote: > > src/linux/routing/link/link.cpp, line 140 > > <https://reviews.apache.org/r/21141/diff/1/?file=575835#file575835line140> > > > > It's checking the negative, i.e., that a link does *not* exist. Can you > > modify the comment and perhaps class to make this clearer?
Modified the comments. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21141/#review42510 ----------------------------------------------------------- On May 7, 2014, 12:29 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21141/ > ----------------------------------------------------------- > > (Updated May 7, 2014, 12:29 a.m.) > > > Review request for mesos, Benjamin Hindman, Chi Zhang, Ian Downes, Vinod > Kone, and Cong Wang. > > > Bugs: MESOS-1228 > https://issues.apache.org/jira/browse/MESOS-1228 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/linux/routing/link/link.hpp PRE-CREATION > src/linux/routing/link/link.cpp PRE-CREATION > src/tests/routing_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/21141/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
