> On May 13, 2014, 1:31 a.m., Vinod Kone wrote: > > src/linux/routing/link/link.hpp, lines 63-66 > > <https://reviews.apache.org/r/21141/diff/1/?file=575834#file575834line63> > > > > Why not have remove() return a Future that gets satisfied when the link > > is removed. Are there other cases where 'wait' will be used? > > > > Also, if we do we need wait, I would recommend > > s/wait/removed/ to be more explicit.
Yeah, in the network isolator, the link will be removed automatically by the kernel. We need to wait for it to be removed explicitly. Changed it to 'removed'. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21141/#review42802 ----------------------------------------------------------- On May 7, 2014, 12:29 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21141/ > ----------------------------------------------------------- > > (Updated May 7, 2014, 12:29 a.m.) > > > Review request for mesos, Benjamin Hindman, Chi Zhang, Ian Downes, Vinod > Kone, and Cong Wang. > > > Bugs: MESOS-1228 > https://issues.apache.org/jira/browse/MESOS-1228 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/linux/routing/link/link.hpp PRE-CREATION > src/linux/routing/link/link.cpp PRE-CREATION > src/tests/routing_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/21141/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
