----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21379/#review43072 -----------------------------------------------------------
src/messages/messages.proto <https://reviews.apache.org/r/21379/#comment77095> I'm not sure why signals are being introduced here? This message is sent from the Master to the Slave, but the master does not need to send a 'signal' number to the slave, right? src/slave/slave.cpp <https://reviews.apache.org/r/21379/#comment77094> It's not thread safe to directly call into the Slave from the signal handler, because the Slave is a Process (Actor) that must be accessed in a serialized manner (through message receiving, 'dispatch', 'defer'). In this case, we would want to 'dispatch' the shutdown event to the slave from the signal handler. - Ben Mahler On May 13, 2014, 2:31 p.m., Alexandra Sava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21379/ > ----------------------------------------------------------- > > (Updated May 13, 2014, 2:31 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-544 > https://issues.apache.org/jira/browse/MESOS-544 > > > Repository: mesos-git > > > Description > ------- > > First phase: Mesos-slave support for "node drain" > > > This phase handles the shutdown of the slave, triggered by SIGUSR1 signal: > * implement a signal handler which is invoked when SIGUSR1 signal is issued > * the signal handler will call the 'shutdown' method from the Slave class, > which shuts down all the frameworks and executors that run on the slave. > > In the next phase, the slave will send an unregistration request to the > master in order to overcome the lag of the health check timer (75 sec). > > > Diffs > ----- > > src/messages/messages.proto 6f6e570b1018d8c54d4b8d811470086832792ec4 > src/slave/slave.hpp a6efad4763a7180daad63689227b46e196e5e1a9 > src/slave/slave.cpp 3a4ae38e06a1c23daafebf5421d996e649a07ca5 > > Diff: https://reviews.apache.org/r/21379/diff/ > > > Testing > ------- > > > Thanks, > > Alexandra Sava > >
