----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21379/#review43524 -----------------------------------------------------------
Bad patch! Reviews applied: [21379] Failed command: ./support/mesos-style.py Error: Checking 453 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/tab,+whitespace/todo src/slave/slave.cpp:154: Lines should be <= 80 characters long [whitespace/line_length] [2] src/slave/slave.cpp:1387: Lines should be <= 80 characters long [whitespace/line_length] [2] Total errors found: 2 - Mesos ReviewBot On May 18, 2014, 10:07 p.m., Alexandra Sava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21379/ > ----------------------------------------------------------- > > (Updated May 18, 2014, 10:07 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-544 > https://issues.apache.org/jira/browse/MESOS-544 > > > Repository: mesos-git > > > Description > ------- > > First phase: Mesos-slave support for "node drain" > > > This phase handles the shutdown of the slave, triggered by SIGUSR1 signal: > * implement a signal handler which is invoked when SIGUSR1 signal is issued > * the signal handler will call the 'shutdown' method from the Slave class, > which shuts down all the frameworks and executors that run on the slave. > > In the next phase, the slave will send an unregistration request to the > master in order to overcome the lag of the health check timer (75 sec). > > > Diffs > ----- > > src/messages/messages.proto 6f6e570b1018d8c54d4b8d811470086832792ec4 > src/slave/slave.hpp 29d2a1607a2b3c4443ea14d1cc2b61a065df3cad > src/slave/slave.cpp 4a8adf0efdd9a230a1f91d8d944fc6145a26b7c4 > > Diff: https://reviews.apache.org/r/21379/diff/ > > > Testing > ------- > > > Thanks, > > Alexandra Sava > >
