----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21442/#review43137 -----------------------------------------------------------
ContainerStatistics is a great idea. How big of a change is it? include/mesos/mesos.proto <https://reviews.apache.org/r/21442/#comment77146> s/`/"/ include/mesos/mesos.proto <https://reviews.apache.org/r/21442/#comment77148> s/names/Names/ s/downcased/downcased./ include/mesos/mesos.proto <https://reviews.apache.org/r/21442/#comment77151> s/events/Events/ End with a period. include/mesos/mesos.proto <https://reviews.apache.org/r/21442/#comment77150> s/Epoch/epoch/ ? include/mesos/mesos.proto <https://reviews.apache.org/r/21442/#comment77152> Why are these doubles instead of uint64? - Vinod Kone On May 14, 2014, 6:04 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21442/ > ----------------------------------------------------------- > > (Updated May 14, 2014, 6:04 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1278 > https://issues.apache.org/jira/browse/MESOS-1278 > > > Repository: mesos-git > > > Description > ------- > > PerfStatistics are an optional field in ResourceStatistics. > > This naming is unfortunate - perhaps we should rename to ContainerStatistics > which includes ResourceStatistics and PerfStatistics? > > > Diffs > ----- > > include/mesos/mesos.proto 8012873f853fdee47f8cb2f5d9dbb7cd8ccc6028 > > Diff: https://reviews.apache.org/r/21442/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > >
