> On May 15, 2014, 11:33 a.m., Vinod Kone wrote: > > include/mesos/mesos.proto, line 446 > > <https://reviews.apache.org/r/21442/diff/1/?file=581574#file581574line446> > > > > s/Epoch/epoch/ ?
Capitalization is correct, see man date: Print the date and time represented by seconds, where seconds is the number of seconds since the Epoch (00:00:00 UTC, January 1, 1970; see time(3)), and can be specified in decimal, octal, or hex. > On May 15, 2014, 11:33 a.m., Vinod Kone wrote: > > include/mesos/mesos.proto, lines 446-447 > > <https://reviews.apache.org/r/21442/diff/1/?file=581574#file581574line446> > > > > Why are these doubles instead of uint64? All other timestamps are doubles and are derived from Time::secs() which is the number of seconds since the Epoch. - Ian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21442/#review43137 ----------------------------------------------------------- On May 14, 2014, 11:04 a.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21442/ > ----------------------------------------------------------- > > (Updated May 14, 2014, 11:04 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1278 > https://issues.apache.org/jira/browse/MESOS-1278 > > > Repository: mesos-git > > > Description > ------- > > PerfStatistics are an optional field in ResourceStatistics. > > This naming is unfortunate - perhaps we should rename to ContainerStatistics > which includes ResourceStatistics and PerfStatistics? > > > Diffs > ----- > > include/mesos/mesos.proto 8012873f853fdee47f8cb2f5d9dbb7cd8ccc6028 > > Diff: https://reviews.apache.org/r/21442/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > >
