----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20918/#review43663 -----------------------------------------------------------
3rdparty/libprocess/include/process/metrics/timer.hpp <https://reviews.apache.org/r/20918/#comment77953> s/stopwatch/Clock/ here and everywhere else. 3rdparty/libprocess/include/process/metrics/timer.hpp <https://reviews.apache.org/r/20918/#comment77954> Why is this pulled out of the locked section? Just do s/stop/Clock::now()/ below? 3rdparty/libprocess/src/tests/metrics_tests.cpp <https://reviews.apache.org/r/20918/#comment77955> yay! 3rdparty/libprocess/src/tests/metrics_tests.cpp <https://reviews.apache.org/r/20918/#comment77956> I'm confused on what this is trying to test. Maybe some comments are in order? - Vinod Kone On May 15, 2014, 5:43 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20918/ > ----------------------------------------------------------- > > (Updated May 15, 2014, 5:43 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1284 > https://issues.apache.org/jira/browse/MESOS-1284 > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > 3rdparty/libprocess/include/process/metrics/timer.hpp > 9236954425354a2d88eaeace353722ba9b40fbd5 > 3rdparty/libprocess/src/tests/metrics_tests.cpp > 8a131218b858a6571bd520c470eac850a3fd345e > > Diff: https://reviews.apache.org/r/20918/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
