> On May 21, 2014, 3:53 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/include/process/metrics/timer.hpp, line 65 > > <https://reviews.apache.org/r/20918/diff/2/?file=582655#file582655line65> > > > > Why is this pulled out of the locked section? Just do > > s/stop/Clock::now()/ below? > > Dominic Hamon wrote: > The stop time should be the time 'stop' is called, not the time the lock > is acquired. > > Vinod Kone wrote: > just to be sure, is this a change in semantics in addition to swapping > clock with stopwatch? afaict, in the stopwatch version the elapsed time was > calculated after the lock was acquired.
it is for start/stop. in the time/_time construct we always stopped the stopwatch outside the lock. Being inside the lock was actually a bug. - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20918/#review43663 ----------------------------------------------------------- On May 22, 2014, 10:30 a.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20918/ > ----------------------------------------------------------- > > (Updated May 22, 2014, 10:30 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1284 > https://issues.apache.org/jira/browse/MESOS-1284 > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > 3rdparty/libprocess/include/process/metrics/timer.hpp > 9236954425354a2d88eaeace353722ba9b40fbd5 > 3rdparty/libprocess/src/tests/metrics_tests.cpp > 8a131218b858a6571bd520c470eac850a3fd345e > > Diff: https://reviews.apache.org/r/20918/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
