What were the linking problems here? It just looks like the 'inline' keyword was missing?
On Thu, May 22, 2014 at 2:45 PM, Till Toenshoff <[email protected]> wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21829/#review43784 > ----------------------------------------------------------- > > Ship it! > > > Ship it! > > Thanks for this quick and proper fix, Dominic. > > - Till Toenshoff > > > On May 22, 2014, 9:40 p.m., Dominic Hamon wrote: > > > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > https://reviews.apache.org/r/21829/ > > ----------------------------------------------------------- > > > > (Updated May 22, 2014, 9:40 p.m.) > > > > > > Review request for mesos, Benjamin Hindman and Till Toenshoff. > > > > > > Repository: mesos-git > > > > > > Description > > ------- > > > > see summary. This also causes problems when building executables that > link against libmesos and include mesos_containerizer.hpp > > > > > > Diffs > > ----- > > > > src/Makefile.am ae576c5eca2eb8787b5a742cd7c5651904f360b2 > > src/usage/usage.hpp af04a6ae5191a154904ca26fb19dd594c4da9246 > > src/usage/usage.cpp PRE-CREATION > > > > Diff: https://reviews.apache.org/r/21829/diff/ > > > > > > Testing > > ------- > > > > make check > > > > > > Thanks, > > > > Dominic Hamon > > > > > >
