----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21598/#review43981 -----------------------------------------------------------
src/jvm/jvm.cpp <https://reviews.apache.org/r/21598/#comment78224> please don't introduce static non-POD objects. See http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Static_and_Global_Variables for details and potential workarounds. - Dominic Hamon On May 16, 2014, 7:02 p.m., Timothy St. Clair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21598/ > ----------------------------------------------------------- > > (Updated May 16, 2014, 7:02 p.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Bugs: MESOS-1354 > https://issues.apache.org/jira/browse/MESOS-1354 > > > Repository: mesos-git > > > Description > ------- > > Fix for the coverity leak and update the code to leverage > stout/dynamiclibrary. > > > Diffs > ----- > > src/jvm/jvm.cpp 745b48f > > Diff: https://reviews.apache.org/r/21598/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy St. Clair > >
