> On May 27, 2014, 4:47 p.m., Dominic Hamon wrote:
> >
>
> Timothy St. Clair wrote:
> Could Ben or Niklas chime in here, I think we are at an impasse below.
>
> Niklas Nielsen wrote:
> I chatted with Ben about this; how about having a static pointer instead?
> It could even be within the Jvm::create():
>
> Jvm::create()
> {
> ...
> static DynamicLibrary* libJvm = NULL;
> if (libJvm == NULL) {
> libJvm = new DynamicLibrary();
> }
> ...
>
> What do you think?
>
> Dominic Hamon wrote:
> you don't need the NULL check (unless it's being set to NULL elsewhere).
>
> This was the suggestion I made below so you know I'm in favour!
ok.
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21598/#review43981
-----------------------------------------------------------
On May 17, 2014, 2:02 a.m., Timothy St. Clair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21598/
> -----------------------------------------------------------
>
> (Updated May 17, 2014, 2:02 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Bugs: MESOS-1354
> https://issues.apache.org/jira/browse/MESOS-1354
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fix for the coverity leak and update the code to leverage
> stout/dynamiclibrary.
>
>
> Diffs
> -----
>
> src/jvm/jvm.cpp 745b48f
>
> Diff: https://reviews.apache.org/r/21598/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy St. Clair
>
>
