----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21833/#review44047 -----------------------------------------------------------
src/tests/containerizer_tests.cpp <https://reviews.apache.org/r/21833/#comment78357> could you also correct the string here to "this is stdout". src/tests/containerizer_tests.cpp <https://reviews.apache.org/r/21833/#comment78356> Let's change this to use printf, as suggested in `man echo`, to not output the \n. - Ian Downes On May 22, 2014, 5:47 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21833/ > ----------------------------------------------------------- > > (Updated May 22, 2014, 5:47 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1413 > https://issues.apache.org/jira/browse/MESOS-1413 > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > src/tests/containerizer_tests.cpp 2f4888d > > Diff: https://reviews.apache.org/r/21833/diff/ > > > Testing > ------- > > make check (OSX and linux) > > > Thanks, > > Till Toenshoff > >
