> On May 27, 2014, 9:48 p.m., Ian Downes wrote: > > src/tests/containerizer_tests.cpp, line 460 > > <https://reviews.apache.org/r/21833/diff/1/?file=588592#file588592line460> > > > > could you also correct the string here to "this is stdout".
How did this ever work? :) > On May 27, 2014, 9:48 p.m., Ian Downes wrote: > > src/tests/containerizer_tests.cpp, line 462 > > <https://reviews.apache.org/r/21833/diff/1/?file=588592#file588592line462> > > > > Let's change this to use printf, as suggested in `man echo`, to not > > output the \n. > > Dominic Hamon wrote: > looking over the rest of the code, we use 'echo' and compare with the > '\n'. for consistency maybe leaving this as echo is better? > > Ian Downes wrote: > works for me! :-) Suggested a proper cleanup in MESOS-1424. For the sake of consistency, I will drop this issue. - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21833/#review44047 ----------------------------------------------------------- On May 27, 2014, 10:42 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21833/ > ----------------------------------------------------------- > > (Updated May 27, 2014, 10:42 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1413 > https://issues.apache.org/jira/browse/MESOS-1413 > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > src/tests/containerizer_tests.cpp 2f4888d > > Diff: https://reviews.apache.org/r/21833/diff/ > > > Testing > ------- > > make check (OSX and linux) > > > Thanks, > > Till Toenshoff > >
