> On May 28, 2014, 10:58 p.m., Ben Mahler wrote: > > Quite the tricky bug! > > > > Is this issue also present in the MesosContainerizer? If so, we should > > probably fix that in this review as well or at least have a ticket to block > > 0.19.0.
Ticket is up and set for blocking: https://issues.apache.org/jira/browse/MESOS-1431 > On May 28, 2014, 10:58 p.m., Ben Mahler wrote: > > src/slave/containerizer/external_containerizer.cpp, lines 1133-1139 > > <https://reviews.apache.org/r/21966/diff/2/?file=597812#file597812line1133> > > > > Wasn't there a separate review already for this cloexec issue? I had bundled these as I had not gotten any reviews on the old version yet, sorry for triggering that confusion. > On May 28, 2014, 10:58 p.m., Ben Mahler wrote: > > src/slave/containerizer/external_containerizer.cpp, line 1148 > > <https://reviews.apache.org/r/21966/diff/2/?file=597812#file597812line1148> > > > > errno at this point is potentially tainted by the call to os::close Ow, good point. I will be switching over to io::redirect, hence get rid of this. > On May 28, 2014, 10:58 p.m., Ben Mahler wrote: > > src/slave/containerizer/external_containerizer.cpp, line 1152 > > <https://reviews.apache.org/r/21966/diff/2/?file=597812#file597812line1152> > > > > Why not have two onAny's instead of the custom '_invoke' function? > > > > e.g. > > > > .onAny(bind(&os::close, fd)) > > .onAny(bind(&os::close, err.get()) Again, good point. I had that extra callback in there for better debugging. - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21966/#review44193 ----------------------------------------------------------- On May 28, 2014, 8:26 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21966/ > ----------------------------------------------------------- > > (Updated May 28, 2014, 8:26 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/containerizer/external_containerizer.cpp b39c845 > > Diff: https://reviews.apache.org/r/21966/diff/ > > > Testing > ------- > > make check as well as Deimos (ECP) intergration tests > > > Thanks, > > Till Toenshoff > >
