----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21966/#review44227 -----------------------------------------------------------
Ship it! src/slave/containerizer/external_containerizer.cpp <https://reviews.apache.org/r/21966/#comment78563> You could not bother setting the close-on-exec flag and just close it immediately after doing the io::redirect rather than via an onAny. It's slightly more exposed to a fork but not too much (and it's just less code in general). You could move the TODO up to the open then. - Benjamin Hindman On May 29, 2014, 2:31 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21966/ > ----------------------------------------------------------- > > (Updated May 29, 2014, 2:31 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-1431 > https://issues.apache.org/jira/browse/MESOS-1431 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/containerizer/external_containerizer.cpp b39c845 > > Diff: https://reviews.apache.org/r/21966/diff/ > > > Testing > ------- > > make check as well as Deimos (ECP) intergration tests > > > Thanks, > > Till Toenshoff > >
