> On May 29, 2014, 4:14 p.m., Adam B wrote: > > src/tests/slave_tests.cpp, lines 725-726 > > <https://reviews.apache.org/r/21968/diff/6/?file=597869#file597869line725> > > > > This could instead go below, just before StartSlave, or above the exec > > definition (first of 3 parameters to StartSlave). I just don't like to see > > the exec/flags/detector parameter setup broken up.
Fixed. > On May 29, 2014, 4:14 p.m., Adam B wrote: > > src/tests/slave_tests.cpp, line 814 > > <https://reviews.apache.org/r/21968/diff/6/?file=597869#file597869line814> > > > > "expectation" and explain in the comment what you're expecting Added a few more explaination. > On May 29, 2014, 4:14 p.m., Adam B wrote: > > src/tests/slave_tests.cpp, line 745 > > <https://reviews.apache.org/r/21968/diff/6/?file=597869#file597869line745> > > > > Why create/run a task at all? I have tested that if there is no tasks running, the slave will terminate immediately, which is not what I expect. Besides, in order to run tasks on the slave, the slave must have registered with the master first... So I did the failover and re-registeration stuff.. - Yifan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21968/#review44245 ----------------------------------------------------------- On May 29, 2014, 10:40 p.m., Yifan Gu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21968/ > ----------------------------------------------------------- > > (Updated May 29, 2014, 10:40 p.m.) > > > Review request for mesos, Adam B and Niklas Nielsen. > > > Bugs: MESOS-878 > https://issues.apache.org/jira/browse/MESOS-878 > > > Repository: mesos-git > > > Description > ------- > > Added a sentence to check the slave's state in doReliableRegistration() to > make sure that the function returns when the slave's state is TERMINATING. > Also, to write the test, I need to make sure there's no additional > doReliableRegistration() calls, so I added NO_FUTURE_PROTOBUFS() and > NO_FUTURE_MESSAGES() to make sure there's no more SlaveReregisteredMessages. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/gmock.hpp daba7e3 > src/slave/slave.cpp 7fbedb1 > src/tests/mesos.hpp 1b0f358 > src/tests/slave_tests.cpp 80fe3cf > > Diff: https://reviews.apache.org/r/21968/diff/ > > > Testing > ------- > > Slave_tests.cpp:TerminatingSlaveDoesNotReregister. > > > Thanks, > > Yifan Gu > >
