> On May 29, 2014, 4:14 p.m., Adam B wrote: > > src/tests/slave_tests.cpp, line 736 > > <https://reviews.apache.org/r/21968/diff/6/?file=597869#file597869line736> > > > > Why needed, to simulate master failover? Can't you just test this > > during initial registration?
See below. > On May 29, 2014, 4:14 p.m., Adam B wrote: > > src/tests/slave_tests.cpp, line 743 > > <https://reviews.apache.org/r/21968/diff/6/?file=597869#file597869line743> > > > > Why wait until registered the first time, instead of testing > > TERMINATING during original registration? See below. - Yifan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21968/#review44245 ----------------------------------------------------------- On May 30, 2014, 9:45 p.m., Yifan Gu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21968/ > ----------------------------------------------------------- > > (Updated May 30, 2014, 9:45 p.m.) > > > Review request for mesos, Adam B, Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-878 > https://issues.apache.org/jira/browse/MESOS-878 > > > Repository: mesos-git > > > Description > ------- > > Added a sentence to check the slave's state in doReliableRegistration() to > make sure that the function returns when the slave's state is TERMINATING. > Also, to write the test, I need to make sure there's no additional > doReliableRegistration() calls, so I added NO_FUTURE_PROTOBUFS() and > NO_FUTURE_MESSAGES() to make sure there's no more SlaveReregisteredMessages. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/gmock.hpp daba7e3 > src/slave/slave.cpp 7fbedb1 > src/tests/mesos.hpp 1b0f358 > src/tests/slave_tests.cpp 80fe3cf > > Diff: https://reviews.apache.org/r/21968/diff/ > > > Testing > ------- > > Slave_tests.cpp:TerminatingSlaveDoesNotReregister. > > > File Attachments > ---------------- > > Using DROP_PROTOBUF() > > https://reviews.apache.org/media/uploaded/files/2014/05/30/7c0e1b69-19c1-4868-865e-d47fbb739585__mesos.diff > > > Thanks, > > Yifan Gu > >
