----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22369/#review45076 -----------------------------------------------------------
Bad patch! Reviews applied: [22369] Failed command: ./support/mesos-style.py Error: Checking 468 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/tab,+whitespace/todo src/master/main.cpp:187: Lines should be <= 80 characters long [whitespace/line_length] [2] src/master/main.cpp:188: Lines should be <= 80 characters long [whitespace/line_length] [2] src/master/main.cpp:201: Lines should be <= 80 characters long [whitespace/line_length] [2] src/master/flags.hpp:70: Tab found; better to use spaces [whitespace/tab] [1] src/master/flags.hpp:71: Tab found; better to use spaces [whitespace/tab] [1] Total errors found: 5 - Mesos ReviewBot On June 9, 2014, 8:52 a.m., Chengwei Yang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22369/ > ----------------------------------------------------------- > > (Updated June 9, 2014, 8:52 a.m.) > > > Review request for mesos. > > > Bugs: https://issues.apache.org/jira/browse/MESOS-1465 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-1465 > > > Repository: mesos-git > > > Description > ------- > > Use '--nr_of_masters' instead of '--quorum' because user may confused > with zookeeper quorum and may specify an incorrect quorum if he/she > doesn't know quorum well. > > Use '--nr_of_masters' just simple and straight-forward, and quorum will > be nr_of_masters / 2 + 1, since specify a larger quorum doesn't make > sense in pratice. > > Review: https://reviews.apache.org/r/22369 > > > Diffs > ----- > > src/master/flags.hpp 486335970ef05b345c5584ac012dde63437ef149 > src/master/main.cpp 8ceaae61a732a8d68d19c8aee97c1fd93a595893 > > Diff: https://reviews.apache.org/r/22369/diff/ > > > Testing > ------- > > done. > > > Thanks, > > Chengwei Yang > >
