----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22369/#review45270 -----------------------------------------------------------
Patch looks great! Reviews applied: [22369] All tests passed. - Mesos ReviewBot On June 10, 2014, 1:03 a.m., Chengwei Yang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22369/ > ----------------------------------------------------------- > > (Updated June 10, 2014, 1:03 a.m.) > > > Review request for mesos. > > > Bugs: https://issues.apache.org/jira/browse/MESOS-1465 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-1465 > > > Repository: mesos-git > > > Description > ------- > > Use '--nr_of_masters' instead of '--quorum' because user may confused > with zookeeper quorum and may specify an incorrect quorum if he/she > doesn't know quorum well. > > Use '--nr_of_masters' just simple and straight-forward, and quorum will > be nr_of_masters / 2 + 1, since specify a larger quorum doesn't make > sense in pratice. > > Review: https://reviews.apache.org/r/22369 > > > Diffs > ----- > > src/master/flags.hpp 4863359 > src/master/main.cpp 8ceaae6 > > Diff: https://reviews.apache.org/r/22369/diff/ > > > Testing > ------- > > done. > > > Thanks, > > Chengwei Yang > >
