----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22066/#review45399 -----------------------------------------------------------
Just a quick note (not a full review) motivating more unit tests. src/master/master.cpp <https://reviews.apache.org/r/22066/#comment80238> Since we're using a delay here, we should write tests that also exercise the possible race conditions, e.g. framework/slave/offer has completed or been removed during the offer_timeout. - Adam B On May 29, 2014, 4:22 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22066/ > ----------------------------------------------------------- > > (Updated May 29, 2014, 4:22 p.m.) > > > Review request for mesos, Adam B and Niklas Nielsen. > > > Bugs: mesos-186 > https://issues.apache.org/jira/browse/mesos-186 > > > Repository: mesos-git > > > Description > ------- > > A timer is associated with each newly created offer. > The offer is rescinded on timeout. > The timer is disarmed on a launchTask or decline. > > > Diffs > ----- > > src/master/flags.hpp e890227 > src/master/master.hpp d4ef4be > src/master/master.cpp 766a0e3 > src/tests/master_tests.cpp 7183cb7 > > Diff: https://reviews.apache.org/r/22066/diff/ > > > Testing > ------- > > Added MasterTest.RescindResourceOffers and ran make check. > > > Thanks, > > Kapil Arya > >
