Hi Ben, Kapil is continuing where I left off and finish the patch (that he originally started himself).
So the one he posted should have all my changes plus addressing your comments. Tim Sent from my iPhone > On Aug 12, 2014, at 2:18 PM, Benjamin Mahler <benjamin.mah...@gmail.com> > wrote: > > Hey Kapil, it looks like Tim had been following up with a separate review for > this: > > https://reviews.apache.org/r/22796/ > > >> On Mon, Aug 11, 2014 at 8:09 PM, Mesos ReviewBot <dev@mesos.apache.org> >> wrote: >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.apache.org/r/22066/#review50281 >> ----------------------------------------------------------- >> >> >> Patch looks great! >> >> Reviews applied: [22066] >> >> All tests passed. >> >> - Mesos ReviewBot >> >> >> On Aug. 9, 2014, 12:57 a.m., Kapil Arya wrote: >> > >> > ----------------------------------------------------------- >> > This is an automatically generated e-mail. To reply, visit: >> > https://reviews.apache.org/r/22066/ >> > ----------------------------------------------------------- >> > >> > (Updated Aug. 9, 2014, 12:57 a.m.) >> > >> > >> > Review request for mesos, Adam B, Ben Mahler, Niklas Nielsen, and Timothy >> > Chen. >> > >> > >> > Bugs: mesos-186 >> > https://issues.apache.org/jira/browse/mesos-186 >> > >> > >> > Repository: mesos-git >> > >> > >> > Description >> > ------- >> > >> > A timer is associated with each newly created offer. >> > The offer is rescinded on timeout. >> > The timer is disarmed on a launchTask or decline. >> > >> > >> > Diffs >> > ----- >> > >> > src/master/flags.hpp 0db4c95 >> > src/master/master.hpp 29e8f49 >> > src/master/master.cpp e688b41 >> > src/tests/master_tests.cpp 9de2424 >> > >> > Diff: https://reviews.apache.org/r/22066/diff/ >> > >> > >> > Testing >> > ------- >> > >> > Added one more test after Tim's patch to test offer is not rescinded once >> > it has been declined. >> > >> > make check >> > >> > >> > Thanks, >> > >> > Kapil Arya >> > >> > >
