----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22526/#review45574 -----------------------------------------------------------
Patch looks great! Reviews applied: [22526] All tests passed. - Mesos ReviewBot On June 13, 2014, 5:27 a.m., Yifan Gu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22526/ > ----------------------------------------------------------- > > (Updated June 13, 2014, 5:27 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Niklas > Nielsen, and Vinod Kone. > > > Bugs: MESOS-1279 > https://issues.apache.org/jira/browse/MESOS-1279 > > > Repository: mesos-git > > > Description > ------- > > Added resizeTask primitive. > > This is just a proof of concept now. I will work on the unit test. > Currently I added one state called "TASK_RESIZE" in state update, so that the > master/framework can get the resize result from the slave. > I put the result in the 'data' field of the TaskStatus. > > And I feel that I copy-pasted a lot of checkers, which is kind mess, I think > they should be put into a separate module later. > > Any question or suggestion is highly welcome! Thanks! > > > Diffs > ----- > > include/mesos/mesos.proto 102289b > src/common/protobuf_utils.hpp 12ff00a > src/master/master.hpp 7a12185 > src/master/master.cpp 4a01b1a > src/messages/messages.proto 8aecc8b > src/slave/slave.hpp 34687e5 > src/slave/slave.cpp 643c088 > > Diff: https://reviews.apache.org/r/22526/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Yifan Gu > >
