-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22526/#review45664
-----------------------------------------------------------



include/mesos/scheduler/scheduler.proto
<https://reviews.apache.org/r/22526/#comment80567>

    Made it an optional field so the master won't need to fill this field when 
sending it to the slave.


- Yifan Gu


On June 13, 2014, 9:58 p.m., Yifan Gu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22526/
> -----------------------------------------------------------
> 
> (Updated June 13, 2014, 9:58 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Niklas 
> Nielsen, and Vinod Kone.
> 
> 
> Bugs: MESOS-1279
>     https://issues.apache.org/jira/browse/MESOS-1279
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Added resizeTask primitive.
> 
> This is just a proof of concept now. I will work on the unit test.
> Currently I added one state called "TASK_RESIZE" in state update, so that the 
> master/framework can get the resize result from the slave.
> I put the result in the 'data' field of the TaskStatus.
> 
> And I feel that I copy-pasted a lot of checkers, which is kind mess, I think 
> they should be put into a separate module later.
> 
> Any question or suggestion is highly welcome! Thanks!
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 102289b 
>   include/mesos/scheduler.hpp d224945 
>   include/mesos/scheduler/scheduler.proto 6ab5089 
>   src/common/protobuf_utils.hpp 12ff00a 
>   src/master/master.hpp 7a12185 
>   src/master/master.cpp 4a01b1a 
>   src/messages/messages.proto 8aecc8b 
>   src/sched/sched.cpp 6e14f1c 
>   src/scheduler/scheduler.cpp 4ae188e 
>   src/slave/slave.hpp 34687e5 
>   src/slave/slave.cpp 643c088 
>   src/tests/master_tests.cpp 34df121 
> 
> Diff: https://reviews.apache.org/r/22526/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Yifan Gu
> 
>

Reply via email to