----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22593/#review45801 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp <https://reviews.apache.org/r/22593/#comment80782> See comments below. You can remove that. src/linux/routing/link/link.hpp <https://reviews.apache.org/r/22593/#comment80783> Should be: "the first interface in the routing table that has an empty 'destination'"? Also, comment on in what situation, None will be returned? src/linux/routing/link/link.hpp <https://reviews.apache.org/r/22593/#comment80784> See comments below. Adjust the comments here. src/linux/routing/link/link.cpp <https://reviews.apache.org/r/22593/#comment80786> Please move this line right below #include "linux/routing/internal.hpp" src/linux/routing/link/link.cpp <https://reviews.apache.org/r/22593/#comment80787> We probably want to return an Error here because the link is supposed to be there. src/linux/routing/link/link.cpp <https://reviews.apache.org/r/22593/#comment80781> Ditto. You should be able to use link::internal::test(IFF_LOOPBACK) to test if a 'link' is a loopback device. src/linux/routing/link/link.cpp <https://reviews.apache.org/r/22593/#comment80788> Return an Error here. src/tests/routing_tests.cpp <https://reviews.apache.org/r/22593/#comment80789> What if eth0 is None? src/tests/routing_tests.cpp <https://reviews.apache.org/r/22593/#comment80790> Ditto. - Jie Yu On June 16, 2014, 7:01 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22593/ > ----------------------------------------------------------- > > (Updated June 16, 2014, 7:01 p.m.) > > > Review request for mesos, Ian Downes, Jie Yu, Vinod Kone, and Cong Wang. > > > Repository: mesos-git > > > Description > ------- > > Routing: added interfaces to find the name of host public and loopback device. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 97215af > src/linux/routing/link/link.hpp 4264a1e > src/linux/routing/link/link.cpp ebcd119 > src/tests/routing_tests.cpp 0e8f61a > > Diff: https://reviews.apache.org/r/22593/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Chi Zhang > >
