----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22593/#review45857 -----------------------------------------------------------
Ship it! src/linux/routing/link/link.cpp <https://reviews.apache.org/r/22593/#comment80881> Doesn't seem to be addressed? src/linux/routing/link/link.cpp <https://reviews.apache.org/r/22593/#comment80880> return Error( rule.link() + " is in the routing table but not in the system"); to be consistent with above. src/linux/routing/link/link.cpp <https://reviews.apache.org/r/22593/#comment80876> I think we should return Error if 'test' is an error or none, instead of moving on silently. if (test.isError()) { return Error(...); } else if (test.isNone()) { return Error(...); } else { return link; } - Jie Yu On June 16, 2014, 11:07 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22593/ > ----------------------------------------------------------- > > (Updated June 16, 2014, 11:07 p.m.) > > > Review request for mesos, Ian Downes, Jie Yu, Nikita Vetoshkin, Vinod Kone, > and Cong Wang. > > > Repository: mesos-git > > > Description > ------- > > Routing: added interfaces to find the name of host public and loopback device. > > > Diffs > ----- > > src/linux/routing/link/link.hpp 4264a1e > src/linux/routing/link/link.cpp ebcd119 > src/tests/routing_tests.cpp 0e8f61a > > Diff: https://reviews.apache.org/r/22593/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Chi Zhang > >
