> On June 17, 2014, 12:28 a.m., Vinod Kone wrote: > > src/tests/slave_tests.cpp, lines 864-865 > > <https://reviews.apache.org/r/22313/diff/7/?file=607038#file607038line864> > > > > You should set these expectations just before you launch the second > > task. Also, why "WillRepeatedly"? Are you expecting more than 2 updates? > > Yifan Gu wrote: > I forgot why I added the WillRepeatedly here, but I guess this is because > the first task will send a TASK_LOST at the end. I will try to verify this in > the new version. Thanks! Vinod! >
Update: I think we need to keep WillRepeatedly here. Since in the cleaning up stage, we are shutting the down the 1, scheduler. 2, master. 3, slave. However the slave can be terminated before the other two, in which case it will send a TASK_LOST to the master. Same situation can be found at https://issues.apache.org/jira/browse/MESOS-1460 - Yifan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22313/#review45858 ----------------------------------------------------------- On June 18, 2014, 5:14 a.m., Yifan Gu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22313/ > ----------------------------------------------------------- > > (Updated June 18, 2014, 5:14 a.m.) > > > Review request for mesos, Ian Downes and Vinod Kone. > > > Bugs: MESOS-886 > https://issues.apache.org/jira/browse/MESOS-886 > > > Repository: mesos-git > > > Description > ------- > > Added __runTask() to wait for the completion of containerizer->update() and > check the result before sending RunTaskMessage. > > > Diffs > ----- > > src/slave/slave.hpp 34687e5 > src/slave/slave.cpp 643c088 > src/tests/slave_tests.cpp 2c8f183 > > Diff: https://reviews.apache.org/r/22313/diff/ > > > Testing > ------- > > SlaveTest, CancelTaskIfContainerizerFails > > Which tests that if the containerizer->update() return a Failure, the task > won't be launched and the scheduler will get TASK_LOST. > > make check > > > File Attachments > ---------------- > > framework will exit > > https://reviews.apache.org/media/uploaded/files/2014/06/18/fbe73273-7aa9-4faa-b1c5-003ab03042a9__issue-886.diff > log > > https://reviews.apache.org/media/uploaded/files/2014/06/18/84d801a0-5c2a-4bb9-901b-e1962031461c__log > > > Thanks, > > Yifan Gu > >
