----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22313/#review46425 -----------------------------------------------------------
src/slave/slave.cpp <https://reviews.apache.org/r/22313/#comment81810> Lets not do this. It is weird that a task is in framework->pending AND executor->launchedTasks. It should be in one place or the other. src/slave/slave.cpp <https://reviews.apache.org/r/22313/#comment81813> Revert this to 'if'. src/slave/slave.cpp <https://reviews.apache.org/r/22313/#comment81811> kill this. src/slave/slave.cpp <https://reviews.apache.org/r/22313/#comment81815> kill this. src/slave/slave.cpp <https://reviews.apache.org/r/22313/#comment81816> s/since the framework is still RUNNING/since it has a pending task/ But as mentioned above, lets revert this to an if. Also, what happens if the executor is "TERMINATING" or "TERMINATED" here? You should probably just return because executorTerminated() will send a TASK_LOST for this task. src/slave/slave.cpp <https://reviews.apache.org/r/22313/#comment81817> On second thought lets not expose the future failure/discarded to frameworks. "Failed to update resources of the container" should be enough. - Vinod Kone On June 19, 2014, 1:30 a.m., Yifan Gu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22313/ > ----------------------------------------------------------- > > (Updated June 19, 2014, 1:30 a.m.) > > > Review request for mesos, Ian Downes and Vinod Kone. > > > Bugs: MESOS-886 > https://issues.apache.org/jira/browse/MESOS-886 > > > Repository: mesos-git > > > Description > ------- > > Added __runTask() to wait for the completion of containerizer->update() and > check the result before sending RunTaskMessage. > > > Diffs > ----- > > src/slave/slave.hpp 34687e5 > src/slave/slave.cpp 643c088 > src/tests/slave_tests.cpp 2c8f183 > > Diff: https://reviews.apache.org/r/22313/diff/ > > > Testing > ------- > > SlaveTest, CancelTaskIfContainerizerFails > > Which tests that if the containerizer->update() return a Failure, the task > won't be launched and the scheduler will get TASK_LOST. > > make check > > > File Attachments > ---------------- > > framework will exit > > https://reviews.apache.org/media/uploaded/files/2014/06/18/fbe73273-7aa9-4faa-b1c5-003ab03042a9__issue-886.diff > log > > https://reviews.apache.org/media/uploaded/files/2014/06/18/84d801a0-5c2a-4bb9-901b-e1962031461c__log > > > Thanks, > > Yifan Gu > >
