----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22817/#review46321 -----------------------------------------------------------
src/master/master.hpp <https://reviews.apache.org/r/22817/#comment81645> "count" might imply a (monotonically increasing) "count"er right? What about: event_queue_messages event_queue_dispatches event_queue_http_requests Would we restrict ourselves too much with the following? queued_message_events queued_dispatch_events queued_http_events It might be good to consider what would we expose for MESOS-1517: recovery_queued_message_events Thoughts? - Ben Mahler On June 20, 2014, 4:56 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22817/ > ----------------------------------------------------------- > > (Updated June 20, 2014, 4:56 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1510 > https://issues.apache.org/jira/browse/MESOS-1510 > > > Repository: mesos-git > > > Description > ------- > > see summary. Renamed metrics so they're grouped correctly in endpoint. > > > Diffs > ----- > > src/master/master.hpp b56e9f4af9dd288e9944987f4802cfd1343cb792 > src/master/master.cpp dcf28adae88d8acc2da9d25b8e54fe4538d193ac > src/tests/master_tests.cpp f0bd1fc14eff811d6a8ea91e020bb7b91dd23a87 > > Diff: https://reviews.apache.org/r/22817/diff/ > > > Testing > ------- > > make check > > ran mesos-local and manually checked endpoint > > > Thanks, > > Dominic Hamon > >
