> On June 20, 2014, 2:01 p.m., Ben Mahler wrote: > > src/master/master.hpp, lines 643-645 > > <https://reviews.apache.org/r/22817/diff/1/?file=614159#file614159line643> > > > > "count" might imply a (monotonically increasing) "count"er right? > > > > What about: > > > > event_queue_messages > > event_queue_dispatches > > event_queue_http_requests > > > > Would we restrict ourselves too much with the following? > > > > queued_message_events > > queued_dispatch_events > > queued_http_events > > > > It might be good to consider what would we expose for MESOS-1517: > > > > recovery_queued_message_events > > > > Thoughts?
an excellent point about _count. i prefer event_queue_* because the terminology for 'event_queue' is already in use. similarly, for MESOS-1517, perhaps 'recovery_event_queue_messages', 'recovery_event_queue_dispatches', etc to clarify that it is a separate event queue. - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22817/#review46321 ----------------------------------------------------------- On June 20, 2014, 3:20 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22817/ > ----------------------------------------------------------- > > (Updated June 20, 2014, 3:20 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1510 > https://issues.apache.org/jira/browse/MESOS-1510 > > > Repository: mesos-git > > > Description > ------- > > see summary. Renamed metrics so they're grouped correctly in endpoint. > > > Diffs > ----- > > src/master/master.hpp b56e9f4af9dd288e9944987f4802cfd1343cb792 > src/master/master.cpp dcf28adae88d8acc2da9d25b8e54fe4538d193ac > src/sched/sched.cpp 6da7159e084418fe5eb5973ae98aeb7ed7c13512 > src/tests/master_tests.cpp f0bd1fc14eff811d6a8ea91e020bb7b91dd23a87 > src/tests/scheduler_tests.cpp f6e837e1d37186770e59e61268b3f9d94c3f81c8 > > Diff: https://reviews.apache.org/r/22817/diff/ > > > Testing > ------- > > make check > > ran mesos-local and manually checked endpoint > > > Thanks, > > Dominic Hamon > >
