----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22837/#review46327 -----------------------------------------------------------
Ship it! src/java/src/org/apache/mesos/Log.java <https://reviews.apache.org/r/22837/#comment81651> Can you add a comment here saying that this constructor is supposed to be used only in test? src/java/src/org/apache/mesos/Log.java <https://reviews.apache.org/r/22837/#comment81652> Ditto. - Jie Yu On June 20, 2014, 8:44 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22837/ > ----------------------------------------------------------- > > (Updated June 20, 2014, 8:44 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-1519 > https://issues.apache.org/jira/browse/MESOS-1519 > > > Repository: mesos-git > > > Description > ------- > > This allows java API users to construct objects in tests without extra > hoop-jumping. > > I also unintentionally built with java 8, which pointed out some javadoc > errors. I've fixed those here. > > > Diffs > ----- > > src/java/src/org/apache/mesos/Executor.java > cacb4e912cd44c5f6feb4a9920f4506e2399dcb7 > src/java/src/org/apache/mesos/Log.java > d27e4f9e226f1aa5588cf75cb8c0a117dbf3015d > src/java/src/org/apache/mesos/SchedulerDriver.java > 591984e66e8eca18f08d719659f325c21f63c2ba > src/java/src/org/apache/mesos/state/State.java > d14d79b4850f677588c928803aba921030571fb8 > > Diff: https://reviews.apache.org/r/22837/diff/ > > > Testing > ------- > > $ make > $ make check > > > Thanks, > > Bill Farner > >
