> On June 20, 2014, 2:54 p.m., John Sirois wrote: > > src/java/src/org/apache/mesos/Log.java, line 36 > > <https://reviews.apache.org/r/22837/diff/1/?file=614348#file614348line36> > > > > It seems like this should go too. > > Any use getting one from the real driver will be doing so through a > > driver-dependent class that actually needs to have a native load. Here > > there are no native bits in-play at all fwict. > > Bill Farner wrote: > I agree in practice, but if some hypothetical person wanted to use the > log independent of the rest of mesos (which seems possible as-is), wouldn't > they be broken by that change?
Yeah - my bad. I failed to expand the bottom context and though this was just Position and Entry. - John ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22837/#review46320 ----------------------------------------------------------- On June 23, 2014, 3:04 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22837/ > ----------------------------------------------------------- > > (Updated June 23, 2014, 3:04 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-1519 > https://issues.apache.org/jira/browse/MESOS-1519 > > > Repository: mesos-git > > > Description > ------- > > This allows java API users to construct objects in tests without extra > hoop-jumping. > > I also unintentionally built with java 8, which pointed out some javadoc > errors. I've fixed those here. > > > Diffs > ----- > > src/java/src/org/apache/mesos/Executor.java > cacb4e912cd44c5f6feb4a9920f4506e2399dcb7 > src/java/src/org/apache/mesos/Log.java > d27e4f9e226f1aa5588cf75cb8c0a117dbf3015d > src/java/src/org/apache/mesos/SchedulerDriver.java > 591984e66e8eca18f08d719659f325c21f63c2ba > src/java/src/org/apache/mesos/state/State.java > d14d79b4850f677588c928803aba921030571fb8 > > Diff: https://reviews.apache.org/r/22837/diff/ > > > Testing > ------- > > $ make > $ make check > > > Thanks, > > Bill Farner > >
